X-Git-Url: https://git.nihav.org/?a=blobdiff_plain;f=nihav-core%2Fsrc%2Fio%2Fcodebook.rs;h=384a743e06191689042923ce1b03032f6ccbe72b;hb=b36f412c24813b14cb2b1f8fd151863e2a49c1e2;hp=0fc6a9cb316b673ca66046464e62d1911b5d00ef;hpb=4a483ccbde256786f3648a525232d0e7772208b4;p=nihav.git diff --git a/nihav-core/src/io/codebook.rs b/nihav-core/src/io/codebook.rs index 0fc6a9c..384a743 100644 --- a/nihav-core/src/io/codebook.rs +++ b/nihav-core/src/io/codebook.rs @@ -113,6 +113,7 @@ pub struct ShortCodebookDesc { /// /// [`ShortCodebookDescReader`]: ./struct.ShortCodebookDescReader.html /// [`TableCodebookDescReader`]: ./struct.TableCodebookDescReader.html +#[allow(clippy::len_without_is_empty)] pub trait CodebookDescReader { /// Returns the codeword length for the provided index. fn bits(&mut self, idx: usize) -> u8; @@ -127,9 +128,9 @@ pub trait CodebookDescReader { /// The codebook structure for code reading. #[allow(dead_code)] pub struct Codebook { - table: Vec, - syms: Vec, - lut_bits: u8, + pub table: Vec, + pub syms: Vec, + pub lut_bits: u8, } /// Trait allowing bitreader to use codebook for decoding bit sequences. @@ -140,7 +141,7 @@ pub trait CodebookReader { fn read_cb(&mut self, cb: &Codebook) -> CodebookResult; } -const TABLE_FILL_VALUE: u32 = 0x7F; +pub const TABLE_FILL_VALUE: u32 = 0x7F; const MAX_LUT_BITS: u8 = 10; fn fill_lut_msb(table: &mut Vec, off: usize, @@ -370,10 +371,10 @@ impl<'a, S: Copy> CodebookReader for BitReader<'a> { let bits = cb.table[lut_idx] & 0x7F; esc = (cb.table[lut_idx] & 0x80) != 0; idx = (cb.table[lut_idx] >> 8) as usize; - if (bits as isize) > self.left() { + let skip_bits = if esc { u32::from(lut_bits) } else { bits }; + if (skip_bits as isize) > self.left() { return Err(CodebookError::InvalidCode); } - let skip_bits = if esc { u32::from(lut_bits) } else { bits }; self.skip(skip_bits as u32).unwrap(); lut_bits = bits as u8; }