X-Git-Url: https://git.nihav.org/?a=blobdiff_plain;f=nihav-core%2Fsrc%2Fio%2Fcodebook.rs;h=384a743e06191689042923ce1b03032f6ccbe72b;hb=b36f412c24813b14cb2b1f8fd151863e2a49c1e2;hp=553f2f9c84e77415580404ae38fb58c092bd465c;hpb=cec9f863d6272d15d51045c3cf16f2db9d779eff;p=nihav.git diff --git a/nihav-core/src/io/codebook.rs b/nihav-core/src/io/codebook.rs index 553f2f9..384a743 100644 --- a/nihav-core/src/io/codebook.rs +++ b/nihav-core/src/io/codebook.rs @@ -113,6 +113,7 @@ pub struct ShortCodebookDesc { /// /// [`ShortCodebookDescReader`]: ./struct.ShortCodebookDescReader.html /// [`TableCodebookDescReader`]: ./struct.TableCodebookDescReader.html +#[allow(clippy::len_without_is_empty)] pub trait CodebookDescReader { /// Returns the codeword length for the provided index. fn bits(&mut self, idx: usize) -> u8; @@ -370,10 +371,10 @@ impl<'a, S: Copy> CodebookReader for BitReader<'a> { let bits = cb.table[lut_idx] & 0x7F; esc = (cb.table[lut_idx] & 0x80) != 0; idx = (cb.table[lut_idx] >> 8) as usize; - if (bits as isize) > self.left() { + let skip_bits = if esc { u32::from(lut_bits) } else { bits }; + if (skip_bits as isize) > self.left() { return Err(CodebookError::InvalidCode); } - let skip_bits = if esc { u32::from(lut_bits) } else { bits }; self.skip(skip_bits as u32).unwrap(); lut_bits = bits as u8; }