X-Git-Url: https://git.nihav.org/?a=blobdiff_plain;f=nihav-duck%2Fsrc%2Fcodecs%2Fdkadpcm.rs;h=712a864bc24d7ae2dcaadbc0696ef75b060a2cc6;hb=5580b11b0e9daf065c81a8b354295c6d5d1dd3dd;hp=041095733181831492ed6f663deb5e04f6c1cb3a;hpb=1a967e6bad5f17943b4de0607078eb940ad5adfe;p=nihav.git

diff --git a/nihav-duck/src/codecs/dkadpcm.rs b/nihav-duck/src/codecs/dkadpcm.rs
index 0410957..712a864 100644
--- a/nihav-duck/src/codecs/dkadpcm.rs
+++ b/nihav-duck/src/codecs/dkadpcm.rs
@@ -16,15 +16,15 @@ impl IMAState {
         }
     }
     fn reset(&mut self, predictor: i16, step: u8) {
-        self.predictor  = predictor as i32;
+        self.predictor  = i32::from(predictor);
         self.step       = step.min(IMA_MAX_STEP) as usize;
     }
     fn expand_sample(&mut self, nibble: u8) -> i16 {
         let istep = (self.step as isize) + (IMA_STEPS[nibble as usize] as isize);
         let sign = (nibble & 8) != 0;
-        let diff = (((2 * (nibble & 7) + 1) as i32) * IMA_STEP_TABLE[self.step]) >> 3;
+        let diff = (i32::from(2 * (nibble & 7) + 1) * IMA_STEP_TABLE[self.step]) >> 3;
         let sample = if !sign { self.predictor + diff } else { self.predictor - diff };
-        self.predictor = sample.max(std::i16::MIN as i32).min(std::i16::MAX as i32);
+        self.predictor = sample.max(i32::from(std::i16::MIN)).min(i32::from(std::i16::MAX));
         self.step = istep.max(0).min(IMA_MAX_STEP as isize) as usize;
         self.predictor as i16
     }
@@ -51,7 +51,7 @@ impl DuckADPCMDecoder {
 }
 
 impl NADecoder for DuckADPCMDecoder {
-    fn init(&mut self, info: Rc<NACodecInfo>) -> DecoderResult<()> {
+    fn init(&mut self, _supp: &mut NADecoderSupport, info: NACodecInfoRef) -> DecoderResult<()> {
         if let NACodecTypeInfo::Audio(ainfo) = info.get_properties() {
             validate!(ainfo.get_block_len() > 16);
             self.block_len = ainfo.get_block_len();
@@ -69,7 +69,7 @@ impl NADecoder for DuckADPCMDecoder {
             Err(DecoderError::InvalidData)
         }
     }
-    fn decode(&mut self, pkt: &NAPacket) -> DecoderResult<NAFrameRef> {
+    fn decode(&mut self, _supp: &mut NADecoderSupport, pkt: &NAPacket) -> DecoderResult<NAFrameRef> {
         let info = pkt.get_stream().get_info();
         if let NACodecTypeInfo::Audio(_) = info.get_properties() {
             let pktbuf = pkt.get_buffer();
@@ -100,7 +100,7 @@ impl NADecoder for DuckADPCMDecoder {
                     self.ch_state[0].reset(sumpred,  sumstep);
                     self.ch_state[1].reset(diffpred, diffstep);
                     let mut last_nib = 0;
-                    let mut diff_val: i32 = diffpred as i32;
+                    let mut diff_val: i32 = i32::from(diffpred);
                     for x in (0..out_block_len).step_by(2) {
                         let nib0;
                         let nib1;
@@ -118,9 +118,9 @@ impl NADecoder for DuckADPCMDecoder {
                             nib1 = b0 & 0xF;
                             nib2 = b0 >> 4;
                         }
-                        let sum0 = self.ch_state[0].expand_sample(nib0) as i32;
-                        let diff = self.ch_state[1].expand_sample(nib1) as i32;
-                        let sum1 = self.ch_state[0].expand_sample(nib2) as i32;
+                        let sum0 = i32::from(self.ch_state[0].expand_sample(nib0));
+                        let diff = i32::from(self.ch_state[1].expand_sample(nib1));
+                        let sum1 = i32::from(self.ch_state[0].expand_sample(nib2));
                         diff_val = (diff_val + diff) >> 1;
                         dst[off0 + x + 0] = (sum0 + diff_val) as i16;
                         dst[off1 + x + 0] = (sum0 - diff_val) as i16;
@@ -158,18 +158,20 @@ impl NADecoder for DuckADPCMDecoder {
             let mut frm = NAFrame::new_from_pkt(pkt, info, abuf);
             frm.set_duration(Some(duration as u64));
             frm.set_keyframe(false);
-            Ok(Rc::new(RefCell::new(frm)))
+            Ok(frm.into_ref())
         } else {
             Err(DecoderError::InvalidData)
         }
     }
+    fn flush(&mut self) {
+    }
 }
 
-pub fn get_decoder_dk3() -> Box<NADecoder> {
+pub fn get_decoder_dk3() -> Box<dyn NADecoder> {
     Box::new(DuckADPCMDecoder::new(true))
 }
 
-pub fn get_decoder_dk4() -> Box<NADecoder> {
+pub fn get_decoder_dk4() -> Box<dyn NADecoder> {
     Box::new(DuckADPCMDecoder::new(false))
 }
 
@@ -188,7 +190,7 @@ mod test {
         duck_register_all_codecs(&mut dec_reg);
 
         let file = "assets/Duck/AVI-DUCK-dk3.duk";
-        test_decode_audio("avi", file, Some(100), "dk3", &dmx_reg, &dec_reg);
+        test_decode_audio("avi", file, Some(100), None/*Some("dk3")*/, &dmx_reg, &dec_reg);
     }
     #[test]
     fn test_dk4() {
@@ -198,7 +200,7 @@ mod test {
         duck_register_all_codecs(&mut dec_reg);
 
         let file = "assets/Duck/virtuafighter2-opening1.avi";
-        test_decode_audio("avi", file, Some(100), "dk4", &dmx_reg, &dec_reg);
+        test_decode_audio("avi", file, Some(100), None/*Some("dk4")*/, &dmx_reg, &dec_reg);
     }
 }