X-Git-Url: https://git.nihav.org/?a=blobdiff_plain;f=nihav-qt%2Fsrc%2Fcodecs%2Fsmc.rs;h=5364b08e680b3c7b0bbf2360d0bb7c5fb371e9d2;hb=3fae33bd60f5575e63cfb1beec82a56a036e47fb;hp=b78c46ba325dd0bcb8ab808e2fbe4646512d9dcf;hpb=78fb6560c73965d834b215fb0b49505ae5443288;p=nihav.git diff --git a/nihav-qt/src/codecs/smc.rs b/nihav-qt/src/codecs/smc.rs index b78c46b..5364b08 100644 --- a/nihav-qt/src/codecs/smc.rs +++ b/nihav-qt/src/codecs/smc.rs @@ -55,15 +55,14 @@ impl NADecoder for SmcDecoder { Err(DecoderError::InvalidData) } } - #[allow(clippy::cyclomatic_complexity)] + #[allow(clippy::cognitive_complexity)] fn decode(&mut self, _supp: &mut NADecoderSupport, pkt: &NAPacket) -> DecoderResult { let src = pkt.get_buffer(); validate!(src.len() >= 2); let mut mr = MemoryReader::new_read(src.as_slice()); let mut br = ByteReader::new(&mut mr); - let id = br.read_byte()?; - validate!(id == 0x80); + let _flags = br.read_byte()?; let length = br.read_u24be()? as usize; validate!(length == src.len()); @@ -120,7 +119,8 @@ impl NADecoder for SmcDecoder { llblock = lblock; }, 2 => { - for i in 0..len { + validate!(blockpos + len * 2 <= nblocks); + for i in 0..len*2 { if (i & 1) == 0 { Self::put_block(&mut frm.data[doff + x..], stride, &llblock); } else { @@ -132,6 +132,7 @@ impl NADecoder for SmcDecoder { doff += stride * 4; } } + blockpos += len; }, 3 => { let clr = br.read_byte()?;