fix (some) clippy warnings

diff --git a/nihav-commonfmt/src/codecs/cinepak.rs b/nihav-commonfmt/src/codecs/cinepak.rs
index ef0b237eaa6d7d85a7c6b9982023fc6010ebbbeb..3c52182eafadaa75d00b581ea58b9ae87beedd72 100644 (file)
--- a/nihav-commonfmt/src/codecs/cinepak.rs
+++ b/nihav-commonfmt/src/codecs/cinepak.rs
@@ -264,11 +264,11 @@ impl NADecoder for CinepakDecoder {
             let ctype                   = br.read_byte()?;
             let csize                   = br.read_u24be()?;
             match ctype {
-                0x20 | 0x21 | 0x22 | 0x23 => {
+                0x20..=0x23 => {
                     mode = DecodeMode::YUV;
                     break;
                 },
-                0x24 | 0x25 | 0x26 | 0x27 => {
+                0x24..=0x27 => {
                     mode = DecodeMode::Gray;
                     break;
                 },

diff --git a/nihav-commonfmt/src/codecs/clearvideo.rs b/nihav-commonfmt/src/codecs/clearvideo.rs
index e6aa568b08e563d5fa5af66efabf2a756090bed0..e2b51010bbb7f5d08d69711fd71d3f2387513d66 100644 (file)
--- a/nihav-commonfmt/src/codecs/clearvideo.rs
+++ b/nihav-commonfmt/src/codecs/clearvideo.rs
@@ -878,7 +878,7 @@ impl NADecoder for ClearVideoDecoder {
             self.frmmgr.clear();
             let edata = info.get_extradata().unwrap_or(std::sync::Arc::new(vec![]));
 //todo detect simply by extradata contents?
-            if edata.len() == 0 || edata.len() < 0x60 { // no or short extradata probably comes from MOV
+            if edata.is_empty() || edata.len() < 0x60 { // no or short extradata probably comes from MOV
                 self.tsize = 4;
             } else if !self.is_rm {
                 let mut br = MemoryReader::new_read(edata.as_slice());

diff --git a/nihav-commonfmt/src/demuxers/mov.rs b/nihav-commonfmt/src/demuxers/mov.rs
index 9b6de5506a383fabb530e0d1937ea6f240e4d532..b5872767e055333ad54292c097c056aca822be5d 100644 (file)
--- a/nihav-commonfmt/src/demuxers/mov.rs
+++ b/nihav-commonfmt/src/demuxers/mov.rs
@@ -347,7 +347,7 @@ fn read_trak(dmx: &mut MOVDemuxer, strmgr: &mut StreamManager, size: u64) -> Dem
             }
         } else if let Some(ref stream) = track.stream {
             if let Some(desc) = get_codec_description(stream.get_info().get_name()) {
-                if (desc.caps & CODEC_CAP_INTRAONLY) != 0 && track.chunk_sizes.len() > 0 {
+                if (desc.caps & CODEC_CAP_INTRAONLY) != 0 && !track.chunk_sizes.is_empty() {
                     for samp in 0..track.chunk_sizes.len() {
                         track.keyframes.push((samp + 1) as u32);
                     }
@@ -1050,8 +1050,8 @@ fn read_tfhd(track: &mut Track, br: &mut dyn ByteIO, size: u64) -> DemuxerResult
     if (flags & 0x000020) != 0 {
         let _default_sample_flags = br.read_u32be()?;
     }
-    if (flags & 0x010000) != 0 {
-    }
+    /*if (flags & 0x010000) != 0 { // duration is empty
+    }*/
     /*if (flags & 0x020000) != 0 { // base offset is moof start
     }*/
     Ok(br.tell() - start)