From 62379cdcd0f60f1f28bb4fb50bd99120db987b3c Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Thu, 13 Jan 2022 18:29:11 +0100 Subject: [PATCH 1/6] ignore MusicMatch tag --- src/demux.rs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/demux.rs b/src/demux.rs index bf8a072..0786275 100644 --- a/src/demux.rs +++ b/src/demux.rs @@ -370,6 +370,27 @@ pub fn detect_tags(br: &mut ByteReader) -> (bool, u64, Option) { end = Some(off - size); } } + // check for MusicMatch tag + let ret = if let Some(endpos) = end { + br.seek(SeekFrom::Start(endpos - 0x30)) + } else { + br.seek(SeekFrom::End(-0x30)) + }; + if ret.is_ok() && br.tell() > (0x2000 - 0x30) { + let mut buf = [0; 19]; + br.peek_buf(&mut buf).unwrap(); + if &buf == b"Brava Software Inc." { + br.seek(SeekFrom::Current(-20)).unwrap(); + let mut mm_start = u64::from(br.read_u32le().unwrap()); + if mm_start > 4 && mm_start + 0x2000 <= br.tell() { + let diff = (br.tell() - mm_start) & 3; + if diff != 0 { + mm_start -= 4 - diff; + } + end = Some(mm_start); + } + } + } (is_raw, start, end) } -- 2.30.2 From 033d6b00ff1e99afb0304800fa1b20322933a5c5 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 5 Nov 2022 10:11:53 +0100 Subject: [PATCH 2/6] rework WAV writer a bit and add 12-bit PCM support --- src/wavwriter.rs | 76 +++++++++++++++++++++++++++++------------------- 1 file changed, 46 insertions(+), 30 deletions(-) diff --git a/src/wavwriter.rs b/src/wavwriter.rs index c0b324d..ab26f6c 100644 --- a/src/wavwriter.rs +++ b/src/wavwriter.rs @@ -79,7 +79,7 @@ impl<'a> WavWriter<'a> { self.io.write_u16le(ainfo.get_channels() as u16)?; self.io.write_u32le(ainfo.get_sample_rate() as u32)?; - if bits < 16 { + if bits <= 8 { self.io.write_u32le((ainfo.get_channels() as u32) * (ainfo.get_sample_rate() as u32))?; self.io.write_u16le(ainfo.get_channels() as u16)?; // block align self.io.write_u16le(8)?; @@ -112,35 +112,51 @@ impl<'a> WavWriter<'a> { write_data!(&mut self.io, buf, write_f32); } NABufferType::AudioPacked(ref buf) => { - if !self.be || self.bits == 8 { - self.io.write_buf(buf.get_data().as_slice())?; - } else { - let data = buf.get_data(); - match self.bits { - 16 => { - for samp in data.chunks(2) { - self.io.write_byte(samp[1])?; - self.io.write_byte(samp[0])?; - } - }, - 24 => { - for samp in data.chunks(3) { - self.io.write_byte(samp[2])?; - self.io.write_byte(samp[1])?; - self.io.write_byte(samp[0])?; - } - }, - 32 => { - for samp in data.chunks(4) { - self.io.write_byte(samp[3])?; - self.io.write_byte(samp[2])?; - self.io.write_byte(samp[1])?; - self.io.write_byte(samp[0])?; - } - }, - _ => unimplemented!(), - }; - } + let data = buf.get_data(); + match self.bits { + _ if !self.be && (self.bits & 7) == 0 => { + self.io.write_buf(data.as_slice())?; + }, + 8 => { + self.io.write_buf(data.as_slice())?; + }, + 12 if !self.be => { + let mut src = data.chunks_exact(3); + while let Some(chunk) = src.next() { + self.io.write_byte(chunk[0] << 4)?; + self.io.write_byte((chunk[1] << 4) | (chunk[0] >> 4))?; + self.io.write_byte(chunk[1] & 0xF0)?; + self.io.write_byte(chunk[2])?; + } + let tail = src.remainder(); + if tail.len() == 2 { + self.io.write_byte(tail[0] << 4)?; + self.io.write_byte(tail[1] << 4)?; + } + } + 16 => { + for samp in data.chunks(2) { + self.io.write_byte(samp[1])?; + self.io.write_byte(samp[0])?; + } + }, + 24 => { + for samp in data.chunks(3) { + self.io.write_byte(samp[2])?; + self.io.write_byte(samp[1])?; + self.io.write_byte(samp[0])?; + } + }, + 32 => { + for samp in data.chunks(4) { + self.io.write_byte(samp[3])?; + self.io.write_byte(samp[2])?; + self.io.write_byte(samp[1])?; + self.io.write_byte(samp[0])?; + } + }, + _ => unimplemented!(), + }; } _ => {}, }; -- 2.30.2 From 8a8f6e5c8847945e274c5d7e2c6a51c027c19c35 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 10 Dec 2022 09:47:40 +0100 Subject: [PATCH 3/6] add option for forcing demuxer --- src/demux.rs | 12 +++++++++++- src/main.rs | 11 ++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/demux.rs b/src/demux.rs index 0786275..56659c7 100644 --- a/src/demux.rs +++ b/src/demux.rs @@ -98,9 +98,19 @@ pub enum DemuxerObject<'a> { } impl<'a> DemuxerObject<'a> { - pub fn create(br: &'a mut ByteReader<'a>, reg: &FullRegister, name: &str, is_raw: bool) -> DemuxerObject<'a> { + pub fn create(br: &'a mut ByteReader<'a>, reg: &FullRegister, name: &str, force_dmx: Option<&str>, is_raw: bool) -> DemuxerObject<'a> { if !is_raw { let res = detect::detect_format(name, br); + if let Some(dmx_name) = force_dmx { + println!("forcing demuxer {} on {}", dmx_name, name); + if let Some(dmx_fact) = reg.dmx_reg.find_demuxer(dmx_name) { + br.seek(SeekFrom::Start(0)).unwrap(); + let dmx = create_demuxer(dmx_fact, br).unwrap(); + return DemuxerObject::Normal(dmx); + } else { + return DemuxerObject::None + } + } let (dmx_name, _) = res.unwrap_or(("", detect::DetectionScore::No)); if dmx_name != "" { println!("trying demuxer {} on {}", dmx_name, name); diff --git a/src/main.rs b/src/main.rs index 8280799..929ab6e 100644 --- a/src/main.rs +++ b/src/main.rs @@ -104,6 +104,7 @@ fn main() { let mut apfx: Option<&str> = None; let mut ignore_errors = false; let mut dump_frames = false; + let mut force_dmx: Option<&str> = None; while (cur_arg < args.len()) && args[cur_arg].starts_with('-') { match args[cur_arg].as_str() { @@ -145,6 +146,14 @@ fn main() { } vpfx = Some(args[cur_arg].clone()); }, + "-demuxer" => { + cur_arg += 1; + if cur_arg == args.len() { + println!("name missing"); + return; + } + force_dmx = Some(&args[cur_arg]); + }, "-ignerr" => { ignore_errors = true; }, "-dumpfrm" => { dump_frames = true; }, _ => { println!("unknown option {}", args[cur_arg]); return; }, @@ -179,7 +188,7 @@ fn main() { } let mut br = ByteReader::new(nfr.as_mut()); let full_reg = FullRegister::new(); - let mut demuxer = DemuxerObject::create(&mut br, &full_reg, name, is_raw); + let mut demuxer = DemuxerObject::create(&mut br, &full_reg, name, force_dmx, is_raw); if demuxer.is_none() { println!("No demuxer found!"); return; -- 2.30.2 From 081797c71bd8cd4342d58a2124cbd7f72d02b7d2 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 17 Dec 2022 11:45:54 +0100 Subject: [PATCH 4/6] add option for printing MOV chunks hierarchy --- src/demux.rs | 10 +++++----- src/main.rs | 6 +++++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/demux.rs b/src/demux.rs index 56659c7..9c65b85 100644 --- a/src/demux.rs +++ b/src/demux.rs @@ -98,14 +98,14 @@ pub enum DemuxerObject<'a> { } impl<'a> DemuxerObject<'a> { - pub fn create(br: &'a mut ByteReader<'a>, reg: &FullRegister, name: &str, force_dmx: Option<&str>, is_raw: bool) -> DemuxerObject<'a> { + pub fn create(br: &'a mut ByteReader<'a>, reg: &FullRegister, name: &str, force_dmx: Option<&str>, is_raw: bool, opts: &[NAOption]) -> DemuxerObject<'a> { if !is_raw { let res = detect::detect_format(name, br); if let Some(dmx_name) = force_dmx { println!("forcing demuxer {} on {}", dmx_name, name); if let Some(dmx_fact) = reg.dmx_reg.find_demuxer(dmx_name) { br.seek(SeekFrom::Start(0)).unwrap(); - let dmx = create_demuxer(dmx_fact, br).unwrap(); + let dmx = create_demuxer_with_options(dmx_fact, br, opts).unwrap(); return DemuxerObject::Normal(dmx); } else { return DemuxerObject::None @@ -116,7 +116,7 @@ impl<'a> DemuxerObject<'a> { println!("trying demuxer {} on {}", dmx_name, name); if let Some(dmx_fact) = reg.dmx_reg.find_demuxer(dmx_name) { br.seek(SeekFrom::Start(0)).unwrap(); - let dmx = create_demuxer(dmx_fact, br).unwrap(); + let dmx = create_demuxer_with_options(dmx_fact, br, opts).unwrap(); return DemuxerObject::Normal(dmx); } } @@ -124,7 +124,7 @@ impl<'a> DemuxerObject<'a> { println!("trying raw demuxer {} on {}", dmx_name, name); if let Some(rdmx_fact) = reg.rdmx_reg.find_demuxer(dmx_name) { br.seek(SeekFrom::Start(0)).unwrap(); - let dmx = create_raw_demuxer(rdmx_fact, br).unwrap(); + let dmx = create_raw_demuxer_with_options(rdmx_fact, br, opts).unwrap(); let mut pkts = Vec::new(); for stream in dmx.get_streams() { if let Some(pcreate) = reg.pkt_reg.find_packetiser(stream.get_info().get_name()) { @@ -141,7 +141,7 @@ impl<'a> DemuxerObject<'a> { if rdmx.check_format(br) { println!("detected {} as {}", name, rdmx.get_name()); br.seek(SeekFrom::Start(0)).unwrap(); - let dmx = create_raw_demuxer(*rdmx, br).unwrap(); + let dmx = create_raw_demuxer_with_options(*rdmx, br, opts).unwrap(); let mut pkts = Vec::new(); for stream in dmx.get_streams() { if let Some(pcreate) = reg.pkt_reg.find_packetiser(stream.get_info().get_name()) { diff --git a/src/main.rs b/src/main.rs index 929ab6e..fcf6a56 100644 --- a/src/main.rs +++ b/src/main.rs @@ -105,6 +105,7 @@ fn main() { let mut ignore_errors = false; let mut dump_frames = false; let mut force_dmx: Option<&str> = None; + let mut demux_opts: Vec = Vec::new(); while (cur_arg < args.len()) && args[cur_arg].starts_with('-') { match args[cur_arg].as_str() { @@ -154,6 +155,9 @@ fn main() { } force_dmx = Some(&args[cur_arg]); }, + "-print_mov_chunks" => { + demux_opts.push(NAOption{name: "print_chunks", value: NAValue::Bool(true) }); + }, "-ignerr" => { ignore_errors = true; }, "-dumpfrm" => { dump_frames = true; }, _ => { println!("unknown option {}", args[cur_arg]); return; }, @@ -188,7 +192,7 @@ fn main() { } let mut br = ByteReader::new(nfr.as_mut()); let full_reg = FullRegister::new(); - let mut demuxer = DemuxerObject::create(&mut br, &full_reg, name, force_dmx, is_raw); + let mut demuxer = DemuxerObject::create(&mut br, &full_reg, name, force_dmx, is_raw, &demux_opts); if demuxer.is_none() { println!("No demuxer found!"); return; -- 2.30.2 From b338b484198691ee7d117a79326af52ae3e1c181 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Wed, 26 Jul 2023 18:51:53 +0200 Subject: [PATCH 5/6] fix clippy warnings --- src/demux.rs | 11 ++++------- src/main.rs | 2 +- src/wavwriter.rs | 10 +++++----- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/src/demux.rs b/src/demux.rs index 9c65b85..9ea9cbb 100644 --- a/src/demux.rs +++ b/src/demux.rs @@ -112,7 +112,7 @@ impl<'a> DemuxerObject<'a> { } } let (dmx_name, _) = res.unwrap_or(("", detect::DetectionScore::No)); - if dmx_name != "" { + if !dmx_name.is_empty() { println!("trying demuxer {} on {}", dmx_name, name); if let Some(dmx_fact) = reg.dmx_reg.find_demuxer(dmx_name) { br.seek(SeekFrom::Start(0)).unwrap(); @@ -120,7 +120,7 @@ impl<'a> DemuxerObject<'a> { return DemuxerObject::Normal(dmx); } } - if dmx_name != "" { + if !dmx_name.is_empty() { println!("trying raw demuxer {} on {}", dmx_name, name); if let Some(rdmx_fact) = reg.rdmx_reg.find_demuxer(dmx_name) { br.seek(SeekFrom::Start(0)).unwrap(); @@ -169,7 +169,7 @@ impl<'a> DemuxerObject<'a> { break; } } - if pname != "" { + if !pname.is_empty() { println!("found raw stream of type {} for {}", pname, name); let pcreate = reg.pkt_reg.find_packetiser(pname).unwrap(); let mut packetiser = (pcreate)(); @@ -182,10 +182,7 @@ impl<'a> DemuxerObject<'a> { } } pub fn is_none(&self) -> bool { - match *self { - DemuxerObject::None => true, - _ => false, - } + matches!(*self, DemuxerObject::None) } pub fn get_duration(&self) -> u64 { match *self { diff --git a/src/main.rs b/src/main.rs index fcf6a56..78c9fb0 100644 --- a/src/main.rs +++ b/src/main.rs @@ -308,7 +308,7 @@ println!("stream {} - {} {}", i, s, info.get_name()); } }, }; - if pkt.get_pts() != None && lastpts != NATimePoint::None && !pkt.ts.less_than(lastpts) { break; } + if pkt.get_pts().is_some() && lastpts != NATimePoint::None && !pkt.ts.less_than(lastpts) { break; } } } //panic!("end"); diff --git a/src/wavwriter.rs b/src/wavwriter.rs index ab26f6c..e32a4ec 100644 --- a/src/wavwriter.rs +++ b/src/wavwriter.rs @@ -77,14 +77,14 @@ impl<'a> WavWriter<'a> { self.io.write_u32le(16)?; self.io.write_u16le(0x0001)?; // PCM self.io.write_u16le(ainfo.get_channels() as u16)?; - self.io.write_u32le(ainfo.get_sample_rate() as u32)?; + self.io.write_u32le(ainfo.get_sample_rate())?; if bits <= 8 { - self.io.write_u32le((ainfo.get_channels() as u32) * (ainfo.get_sample_rate() as u32))?; + self.io.write_u32le((ainfo.get_channels() as u32) * ainfo.get_sample_rate())?; self.io.write_u16le(ainfo.get_channels() as u16)?; // block align self.io.write_u16le(8)?; } else { - self.io.write_u32le(2 * (ainfo.get_channels() as u32) * (ainfo.get_sample_rate() as u32))?; + self.io.write_u32le(2 * (ainfo.get_channels() as u32) * ainfo.get_sample_rate())?; self.io.write_u16le((2 * ainfo.get_channels()) as u16)?; // block align self.io.write_u16le(16)?; } @@ -122,7 +122,7 @@ impl<'a> WavWriter<'a> { }, 12 if !self.be => { let mut src = data.chunks_exact(3); - while let Some(chunk) = src.next() { + for chunk in src.by_ref() { self.io.write_byte(chunk[0] << 4)?; self.io.write_byte((chunk[1] << 4) | (chunk[0] >> 4))?; self.io.write_byte(chunk[1] & 0xF0)?; @@ -172,7 +172,7 @@ impl<'a> Drop for WavWriter<'a> { let res = self.io.seek(SeekFrom::Start(4)); let res = self.io.write_u32le((size - 8) as u32); let res = self.io.seek(SeekFrom::Start(self.data_pos - 4)); - let res = self.io.write_u32le(((size as u64) - self.data_pos) as u32); + let res = self.io.write_u32le((size - self.data_pos) as u32); let res = self.io.flush(); } } -- 2.30.2 From 240018e14cb8ace15aec6cf0dde92b794f26f553 Mon Sep 17 00:00:00 2001 From: Kostya Shishkov Date: Sat, 27 Apr 2024 13:42:12 +0200 Subject: [PATCH 6/6] use NAPacketiser::attach_stream() where appropriate --- src/demux.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/demux.rs b/src/demux.rs index 9ea9cbb..1dc78c5 100644 --- a/src/demux.rs +++ b/src/demux.rs @@ -128,7 +128,8 @@ impl<'a> DemuxerObject<'a> { let mut pkts = Vec::new(); for stream in dmx.get_streams() { if let Some(pcreate) = reg.pkt_reg.find_packetiser(stream.get_info().get_name()) { - let packetiser = (pcreate)(); + let mut packetiser = (pcreate)(); + packetiser.attach_stream(stream); pkts.push(Some(packetiser)); } else { pkts.push(None); -- 2.30.2