X-Git-Url: https://git.nihav.org/?p=nihav.git;a=blobdiff_plain;f=nihav-game%2Fsrc%2Fcodecs%2Fbmv.rs;h=31fd8556f495d141d0529ed36a3fcd1d872516f3;hp=79b8745b17cdd529017e9e2e74b240eb5bc39355;hb=HEAD;hpb=2422d9699cd56cbb86ac32b3e8dd026e20a89db5 diff --git a/nihav-game/src/codecs/bmv.rs b/nihav-game/src/codecs/bmv.rs index 79b8745..31fd855 100644 --- a/nihav-game/src/codecs/bmv.rs +++ b/nihav-game/src/codecs/bmv.rs @@ -84,11 +84,7 @@ impl<'a> BMVWriter<'a> { for _ in 0..len { let saddr = (self.pos as isize) + self.off; if saddr < 0 { continue; } - if self.fwd { - self.data[self.pos] = self.data[saddr as usize]; - } else { - self.data[self.pos] = self.data[saddr as usize]; - } + self.data[self.pos] = self.data[saddr as usize]; self.advance(); } } @@ -146,7 +142,7 @@ impl BMVVideoDecoder { } validate!(val >= 2); let len = (val >> 1) - 1; - + match mode { 1 => bw.copy(len), 2 => for _ in 0..len { bw.put_byte(br.get_byte()); }, @@ -169,7 +165,7 @@ impl BMVVideoDecoder { } impl NADecoder for BMVVideoDecoder { - fn init(&mut self, info: NACodecInfoRef) -> DecoderResult<()> { + fn init(&mut self, _supp: &mut NADecoderSupport, info: NACodecInfoRef) -> DecoderResult<()> { if let NACodecTypeInfo::Video(_vinfo) = info.get_properties() { let fmt = NAPixelFormaton::new(ColorModel::RGB(RGBSubmodel::RGB), Some(NAPixelChromaton::new(0, 0, true, 8, 0, 0, 3)), @@ -185,7 +181,7 @@ impl NADecoder for BMVVideoDecoder { Err(DecoderError::InvalidData) } } - fn decode(&mut self, pkt: &NAPacket) -> DecoderResult { + fn decode(&mut self, _supp: &mut NADecoderSupport, pkt: &NAPacket) -> DecoderResult { let src = pkt.get_buffer(); validate!(src.len() > 1); @@ -210,9 +206,7 @@ impl NADecoder for BMVVideoDecoder { } let pos = br.tell() as usize; - let bufret = alloc_video_buffer(self.info.get_properties().get_video_info().unwrap(), 0); - if let Err(_) = bufret { return Err(DecoderError::InvalidData); } - let mut bufinfo = bufret.unwrap(); + let mut bufinfo = alloc_video_buffer(self.info.get_properties().get_video_info().unwrap(), 0)?; self.decode_frame(&src[pos..], &mut bufinfo, line)?; @@ -220,12 +214,20 @@ impl NADecoder for BMVVideoDecoder { let mut frm = NAFrame::new_from_pkt(pkt, self.info.clone(), bufinfo); frm.set_keyframe(is_intra); frm.set_frame_type(if is_intra { FrameType::I } else { FrameType::P }); - Ok(Rc::new(RefCell::new(frm))) + Ok(frm.into_ref()) } + fn flush(&mut self) { + } +} + +impl NAOptionHandler for BMVVideoDecoder { + fn get_supported_options(&self) -> &[NAOptionDefinition] { &[] } + fn set_options(&mut self, _options: &[NAOption]) { } + fn query_option_value(&self, _name: &str) -> Option { None } } -pub fn get_decoder_video() -> Box { +pub fn get_decoder_video() -> Box { Box::new(BMVVideoDecoder::new()) } @@ -246,7 +248,7 @@ impl BMVAudioDecoder { } fn scale_sample(samp: u8, scale: i32) -> i16 { - let val = (((samp as i8) as i32) * scale) >> 5; + let val = (i32::from(samp as i8) * scale) >> 5; if val < -32768 { -32768 } else if val > 32767 { @@ -257,7 +259,7 @@ fn scale_sample(samp: u8, scale: i32) -> i16 { } impl NADecoder for BMVAudioDecoder { - fn init(&mut self, info: NACodecInfoRef) -> DecoderResult<()> { + fn init(&mut self, _supp: &mut NADecoderSupport, info: NACodecInfoRef) -> DecoderResult<()> { if let NACodecTypeInfo::Audio(ainfo) = info.get_properties() { self.ainfo = NAAudioInfo::new(ainfo.get_sample_rate(), ainfo.get_channels(), formats::SND_S16P_FORMAT, 32); self.chmap = NAChannelMap::from_str("L,R").unwrap(); @@ -266,7 +268,7 @@ impl NADecoder for BMVAudioDecoder { Err(DecoderError::InvalidData) } } - fn decode(&mut self, pkt: &NAPacket) -> DecoderResult { + fn decode(&mut self, _supp: &mut NADecoderSupport, pkt: &NAPacket) -> DecoderResult { let info = pkt.get_stream().get_info(); if let NACodecTypeInfo::Audio(_) = info.get_properties() { let pktbuf = pkt.get_buffer(); @@ -294,14 +296,22 @@ impl NADecoder for BMVAudioDecoder { let mut frm = NAFrame::new_from_pkt(pkt, info, abuf); frm.set_duration(Some(samples as u64)); frm.set_keyframe(false); - Ok(Rc::new(RefCell::new(frm))) + Ok(frm.into_ref()) } else { Err(DecoderError::InvalidData) } } + fn flush(&mut self) { + } +} + +impl NAOptionHandler for BMVAudioDecoder { + fn get_supported_options(&self) -> &[NAOptionDefinition] { &[] } + fn set_options(&mut self, _options: &[NAOption]) { } + fn query_option_value(&self, _name: &str) -> Option { None } } -pub fn get_decoder_audio() -> Box { +pub fn get_decoder_audio() -> Box { Box::new(BMVAudioDecoder::new()) } @@ -309,31 +319,28 @@ pub fn get_decoder_audio() -> Box { mod test { use nihav_core::codecs::RegisteredDecoders; use nihav_core::demuxers::RegisteredDemuxers; - use nihav_core::test::dec_video::*; - use crate::codecs::game_register_all_codecs; - use crate::demuxers::game_register_all_demuxers; + use nihav_codec_support::test::dec_video::*; + use crate::game_register_all_decoders; + use crate::game_register_all_demuxers; + // samples from: https://samples.mplayerhq.hu/game-formats/bmv/ #[test] fn test_bmv_video() { let mut dmx_reg = RegisteredDemuxers::new(); game_register_all_demuxers(&mut dmx_reg); let mut dec_reg = RegisteredDecoders::new(); - game_register_all_codecs(&mut dec_reg); + game_register_all_decoders(&mut dec_reg); -// let file = "assets/Game/PERFECT.BMV"; -// let file = "assets/Game/DW2-MOUSE.BMV"; - let file = "assets/Game/WILDCAT.BMV"; - test_file_decoding("bmv", file, Some(40), true, false, None, &dmx_reg, &dec_reg); + test_decoding("bmv", "bmv-video", "assets/Game/WILDCAT.BMV", Some(40), &dmx_reg, &dec_reg, + ExpectedTestResult::MD5([0x9e91bb16, 0xc1edafc9, 0x4ef3171f, 0x0f3f6181])); } #[test] fn test_bmv_audio() { let mut dmx_reg = RegisteredDemuxers::new(); game_register_all_demuxers(&mut dmx_reg); let mut dec_reg = RegisteredDecoders::new(); - game_register_all_codecs(&mut dec_reg); + game_register_all_decoders(&mut dec_reg); - let file = "assets/Game/PERFECT.BMV"; -// let file = "assets/Game/DW2-MOUSE.BMV"; -// let file = "assets/Game/WILDCAT.BMV"; - test_decode_audio("bmv", file, None, "bmv", &dmx_reg, &dec_reg); + test_decoding("bmv", "bmv-audio", "assets/Game/PERFECT.BMV", None, &dmx_reg, &dec_reg, + ExpectedTestResult::MD5([0x90b9ace4, 0x5fc19938, 0x7f534560, 0x32589cdf])); } }