try to improve state handling in decoding threads
[nihav-player.git] / videoplayer / src / main.rs
index 08b43cb55044dc11f2acf6fe50aafa69112efb50..fa2c4d5bb143bdd9d1b788c33a3f0e0ade6dcdcf 100644 (file)
@@ -9,6 +9,7 @@ use std::io::Write;
 use std::path::Path;
 use std::time::{Duration, Instant};
 use std::thread;
+use std::sync::atomic::{AtomicU8, Ordering};
 
 use sdl2::event::{Event, WindowEvent};
 use sdl2::keyboard::Keycode;
@@ -33,6 +34,55 @@ use videodec::*;
 mod osd;
 use osd::*;
 
+#[repr(u8)]
+#[derive(Clone,Copy,Debug,PartialEq)]
+enum DecodingState {
+    Normal,
+    Waiting,
+    Flush,
+    Prefetch,
+    Error,
+    End,
+}
+
+impl Default for DecodingState {
+    fn default() -> Self { DecodingState::Normal }
+}
+
+impl From<u8> for DecodingState {
+    fn from(val: u8) -> Self {
+        match val {
+            0 => DecodingState::Normal,
+            1 => DecodingState::Waiting,
+            2 => DecodingState::Flush,
+            3 => DecodingState::Prefetch,
+            4 => DecodingState::End,
+            _ => DecodingState::Error,
+        }
+    }
+}
+
+struct DecoderState {
+    state:  AtomicU8
+}
+
+impl DecoderState {
+    const fn new() -> Self {
+        Self {
+            state:  AtomicU8::new(DecodingState::Normal as u8)
+        }
+    }
+    fn set_state(&self, state: DecodingState) {
+        self.state.store(state as u8, Ordering::Release);
+    }
+    fn get_state(&self) -> DecodingState {
+        self.state.load(Ordering::Acquire).into()
+    }
+    fn is_flushing(&self) -> bool {
+        matches!(self.get_state(), DecodingState::Flush | DecodingState::Error)
+    }
+}
+
 #[cfg(feature="debug")]
 macro_rules! debug_log {
     ($log: expr; $blk: block) => {
@@ -315,7 +365,7 @@ impl Player {
             logfile:        File::create("debug.log").unwrap(),
         }
     }
-    fn seek(&mut self, off: u64, fwd: bool, dmx: &mut Demuxer, disp_queue: &mut DispQueue) {
+    fn seek(&mut self, off: u64, fwd: bool, dmx: &mut Demuxer, disp_queue: &mut DispQueue) -> Result<(), ()> {
         let cur_time = self.tkeep.get_cur_time();
         let seektime = if fwd { cur_time + off * 1000 } else {
                 cur_time.saturating_sub(off * 1000) };
@@ -324,7 +374,7 @@ impl Player {
         let ret = dmx.seek(NATimePoint::Milliseconds(seektime));
         if ret.is_err() {
             println!(" seek error");
-            return;
+            return Ok(()); //TODO: not ignore some of seek errors?
         }
 
         self.acontrol.flush();
@@ -332,7 +382,7 @@ impl Player {
         disp_queue.flush();
 
         self.tkeep.reset_ts();
-        self.prefill(dmx, disp_queue);
+        self.prefill(dmx, disp_queue)?;
         if !disp_queue.is_empty() {
             self.tkeep.reset_all(disp_queue.first_ts);
         } else {
@@ -351,8 +401,9 @@ impl Player {
         if !self.paused {
             self.acontrol.resume();
         }
+        Ok(())
     }
-    fn prefill(&mut self, dmx: &mut Demuxer, disp_queue: &mut DispQueue) {
+    fn prefill(&mut self, dmx: &mut Demuxer, disp_queue: &mut DispQueue) -> Result<(), ()> {
         debug_log!(self; {" prefilling"});
         while self.vcontrol.get_queue_size() < FRAME_QUEUE_LEN {
             let mut try_send = self.acontrol.get_queue_size() < FRAME_QUEUE_LEN && (!self.has_video || (!self.vcontrol.is_filled(FRAME_QUEUE_LEN) && !disp_queue.is_full()));
@@ -389,10 +440,11 @@ impl Player {
                 self.vcontrol.fill(disp_queue);
                 std::thread::sleep(Duration::from_millis(10));
             }
-            self.vcontrol.wait_for_frames();
+            self.vcontrol.wait_for_frames()?;
             self.vcontrol.fill(disp_queue);
         }
         debug_log!(self; {format!(" prefilling done, frames {}-{} audio {}", disp_queue.start, disp_queue.end, self.acontrol.get_fill())});
+        Ok(())
     }
     fn toggle_pause(&mut self) {
         self.paused = !self.paused;
@@ -409,12 +461,12 @@ impl Player {
             self.acontrol.resume();
         }
     }
-    fn handle_events(&mut self, event_pump: &mut sdl2::EventPump, canvas: &mut Canvas<Window>, dmx: &mut Demuxer, disp_queue: &mut DispQueue) -> bool {
+    fn handle_events(&mut self, event_pump: &mut sdl2::EventPump, canvas: &mut Canvas<Window>, dmx: &mut Demuxer, disp_queue: &mut DispQueue) -> Result<bool, ()> {
         for event in event_pump.poll_iter() {
             if let Event::Quit {..} = event {
                 self.end = true;
                 println!();
-                return true;
+                return Ok(true);
             }
             if let Event::Window {win_event: WindowEvent::Exposed, ..} = event {
                 canvas.clear();
@@ -429,15 +481,15 @@ impl Player {
                     Keycode::Escape | Keycode::Q => {
                         self.end = true;
                         println!();
-                        return true;
+                        return Ok(true);
                     },
-                    Keycode::Return => return true,
-                    Keycode::Right      => { self.seek(10, true,  dmx, disp_queue); },
-                    Keycode::Left       => { self.seek(10, false, dmx, disp_queue); },
-                    Keycode::Up         => { self.seek(60, true,  dmx, disp_queue); },
-                    Keycode::Down       => { self.seek(60, false, dmx, disp_queue); },
-                    Keycode::PageUp     => { self.seek(600, true,  dmx, disp_queue); },
-                    Keycode::PageDown   => { self.seek(600, false, dmx, disp_queue); },
+                    Keycode::Return => return Ok(true),
+                    Keycode::Right      => { self.seek(10, true,  dmx, disp_queue)?; },
+                    Keycode::Left       => { self.seek(10, false, dmx, disp_queue)?; },
+                    Keycode::Up         => { self.seek(60, true,  dmx, disp_queue)?; },
+                    Keycode::Down       => { self.seek(60, false, dmx, disp_queue)?; },
+                    Keycode::PageUp     => { self.seek(600, true,  dmx, disp_queue)?; },
+                    Keycode::PageDown   => { self.seek(600, false, dmx, disp_queue)?; },
                     Keycode::Space => { self.toggle_pause(); },
                     Keycode::Plus | Keycode::KpPlus => {
                         self.volume = (self.volume + 10).min(MAX_VOLUME);
@@ -476,7 +528,7 @@ impl Player {
                 }
             }
         }
-        false
+        Ok(false)
     }
     fn play(&mut self, name: &str, start_time: NATimePoint) {
         debug_log!(self; {format!("Playing {}", name)});
@@ -671,7 +723,13 @@ impl Player {
         }
 
         // play
-        self.prefill(&mut dmx, &mut disp_q);
+        if self.prefill(&mut dmx, &mut disp_q).is_err() {
+            std::mem::swap(&mut self.vcontrol, &mut new_vcontrol);
+            new_vcontrol.finish();
+            std::mem::swap(&mut self.acontrol, &mut new_acontrol);
+            new_acontrol.finish();
+            return;
+        }
         self.tkeep.reset_all(if !disp_q.is_empty() { disp_q.first_ts } else { 0 });
         if !self.paused {
             self.acontrol.resume();
@@ -680,7 +738,8 @@ impl Player {
         let mut last_disp = Instant::now();
         let mut has_data = true;
         'main: loop {
-            if self.handle_events(&mut event_pump, &mut canvas, &mut dmx, &mut disp_q) {
+            let ret = self.handle_events(&mut event_pump, &mut canvas, &mut dmx, &mut disp_q);
+            if matches!(ret, Ok(true) | Err(_)) {
                 println!();
                 break 'main;
             }