make validate!() print message only in debug builds

[nihav.git] / nihav-realmedia / src / codecs / mod.rs

diff --git a/nihav-realmedia/src/codecs/mod.rs b/nihav-realmedia/src/codecs/mod.rs
index c5ff9bcc232dc5ff9bef8c7eeed38d696222d638..6ca76ac00948aa59bd460344462e0e17cdca0dc3 100644 (file)
--- a/nihav-realmedia/src/codecs/mod.rs
+++ b/nihav-realmedia/src/codecs/mod.rs
@@ -1,8 +1,13 @@
 use nihav_core::codecs::*;
 
+#[cfg(debug_assertions)]
 macro_rules! validate {
     ($a:expr) => { if !$a { println!("check failed at {}:{}", file!(), line!()); return Err(DecoderError::InvalidData); } };
 }
+#[cfg(not(debug_assertions))]
+macro_rules! validate {
+    ($a:expr) => { if !$a { return Err(DecoderError::InvalidData); } };
+}
 
 #[cfg(any(feature="decoder_realvideo3", feature="decoder_realvideo4"))]
 mod rv3040;
@@ -41,6 +46,7 @@ pub mod rv60codes;
 pub mod rv60dsp;
 
 #[cfg(feature="decoder_realaudio144")]
+#[allow(clippy::manual_memcpy)]
 pub mod ra144;
 #[cfg(feature="decoder_realaudio288")]
 pub mod ra288;
@@ -71,8 +77,9 @@ const RM_CODECS: &[DecoderInfo] = &[
     DecoderInfo { name: "ralf", get_decoder: ralf::get_decoder },
 ];
 
-pub fn realmedia_register_all_codecs(rd: &mut RegisteredDecoders) {
+/// Registers all available codecs provided by this crate.
+pub fn realmedia_register_all_decoders(rd: &mut RegisteredDecoders) {
     for decoder in RM_CODECS.iter() {
-        rd.add_decoder(decoder.clone());
+        rd.add_decoder(*decoder);
     }
 }